Vendor fprettify autoformater and add to CI#167
Merged
danielhollas merged 3 commits intomasterfrom Nov 1, 2023
Merged
Conversation
danielhollas
force-pushed
the
vendor-fprettify
branch
from
1834e0a to
592c998
Compare
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 43 43
Lines 6084 6084
Branches 741 741
=======================================
Hits 5620 5620
Misses 452 452
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
danielhollas
force-pushed
the
vendor-fprettify
branch
2 times, most recently
from
40f4c1c to
e604927
Compare
JanosJiri
approved these changes
Nov 1, 2023
Contributor
JanosJiri
left a comment
JanosJiri
left a comment
There was a problem hiding this comment.
Seems to do nice formatting of the code.
danielhollas
force-pushed
the
vendor-fprettify
branch
from
4fdd5ae to
f9f0615
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately,
fprettifyautoformatter is not maintained much, and we need some fixes for it to work for ABIN. So we simply copy the source code with the fixes in the repo to make our lives simpler. The code can now be autoformatted simply by running(assuming the
configargparsePython module is installed.)The formatter source code is vendored in
fprettify/(no need to review those files).We now check the formatting in Github Actions, I've modified
CONTRIBUTING.mdaccordingly.