Rename r.abin to run.abin.sh#191
Merged
danielhollas merged 2 commits intomasterfrom Jan 6, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 92.76% 92.84% +0.07%
==========================================
Files 47 47
Lines 6693 6760 +67
Branches 757 764 +7
==========================================
+ Hits 6209 6276 +67
Misses 472 472
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
JanosJiri
approved these changes
Nov 30, 2024
Contributor
JanosJiri
left a comment
JanosJiri
left a comment
There was a problem hiding this comment.
Renaming r.abin seems like a good idea. I would maybe use run.terachem_mpi_abin.sh instead of run.tc_mpi_abin.sh. Not everyone will know that tc means terachem.
Contributor
Author
Agreed, I've renamed them based on your suggestion. I've also resolved issues reported in #196 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to rename
r.abinand similar scripts, since the name can be a bit weird to newcommers. For now I decided forrun.abin.sh, but I would love to hear feedback on the naming!Closes #146.
Closes #196