Harden TC-MPI connection (handle empty port case)#41
Merged
danielhollas merged 2 commits intomasterfrom Oct 14, 2020
Merged
Conversation
Not sure if this solved the actual issue, but it certainly does not hurt to have it.
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 54.70% 54.65% -0.05%
==========================================
Files 34 34
Lines 5528 5533 +5
==========================================
Hits 3024 3024
- Misses 2504 2509 +5
|
Contributor
Author
|
Codecov is complaining again that the new code is not tested, but I'll probably merge this and open separate PR for TC-MPI interface tests. |
suchanj
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changed was lying in my ARGON repo for a while so I don't remember the context fully,
but apparently I had some issues with TeraChem-MPI interface.
Not sure if this solved the actual issue, but it certainly does not hurt to have it.
We will need to do a thorough testing of this before we compile and release the new ABIN binary on ARGON.