Fix Makefile for Plumed#44
Merged
danielhollas merged 1 commit intomasterfrom Nov 2, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 54.67% 54.98% +0.31%
==========================================
Files 34 34
Lines 5533 5325 -208
==========================================
- Hits 3025 2928 -97
+ Misses 2508 2397 -111
|
Incorrect parameter passed to test.sh However, as noted in the TODO comments, the current approach is still fairly brittle.
danielhollas
force-pushed
the
fix-plumed-makefile
branch
from
01a2d51 to
a7dc3c2
Compare
suchanj
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect parameter passed to test.sh. I also added a lot of TODO comments for future improvements/cleanup around Makefile.
This type of problem will be caught once we include PLUMED in Github Actions build.