Bug - Datetime at DefaultValueBinder

[phackwer]

Greetings!

Line 86 is buggy since it didn't check if the value of the array is an object or instance of DateTime.

Here is the fix! A small check of time and conversion to string.

format('Y-m-d H:i:s'); } else if (is_object($value)) { $value = $value->__toString(); } // Set value explicit $cell->setValueExplicit( $value, self::dataTypeForValue($value) ); // Done! return TRUE; } /** - DataType for value * - @param mixed $pValue - @return string _/ public static function dataTypeForValue($pValue = null) { // Match the value against a few data types if (is_null($pValue)) { return PHPExcel_Cell_DataType::TYPE_NULL; } elseif ($pValue === '') { return PHPExcel_Cell_DataType::TYPE_STRING; } elseif ($pValue instanceof PHPExcel_RichText) { return PHPExcel_Cell_DataType::TYPE_INLINE; } elseif ($pValue{0} === '=' && strlen($pValue) > 1) { return PHPExcel_Cell_DataType::TYPE_FORMULA; } elseif (is_bool($pValue)) { return PHPExcel_Cell_DataType::TYPE_BOOL; } elseif (is_float($pValue) || is_int($pValue)) { return PHPExcel_Cell_DataType::TYPE_NUMERIC; } elseif (preg_match('/^-?([0-9]+\.?[0-9]_|[0-9]*\.?[0-9]+)$/', $pValue)) { return PHPExcel_Cell_DataType::TYPE_NUMERIC; } elseif (is_string($pValue) && array_key_exists($pValue, PHPExcel_Cell_DataType::getErrorCodes())) { return PHPExcel_Cell_DataType::TYPE_ERROR; } else { return PHPExcel_Cell_DataType::TYPE_STRING; } } }

[brunowego]

+1

[MarkBaker]

As it stands, it'll break Rich Text objects, and I'm not sure if it needs any special handling for objects without a __toString() method (possibly throw some kind of catchable exception, although that requires a custom error handler to convert a catchable fatal error to an exception)

[phackwer]

I agree, but anyone who wants to insert any non-SPL object should be obligated to write a __toString method. It's not a bad habit.

[phackwer]

Another thing that would be good is to be able to set date mask as a configuration item. So, I could do something like

PHPExcel::setDateTimeMask('d/m/Y H:i:s');

[MarkBaker]

If you want something that will allow you to define a mask, then you want to use a custom value binder, more like the advanced value binder

[phackwer]

Humm... The problem in this case is that I do not have a clue of what will come, since it's a generic export-to-excel function. Anything can come. So, we basically have these two options only.

Also, the __toString could be done by only serializing the object if __toString is not avaliable.

But the DateTime is a constant: we do have this issue and formating is not a problem, since people could set it later on Excel.

[phackwer]

The real problem is having an \Exception throw due the lack of a default solution.