Inline xfIndexes search in PHPExcel_Style::applyFromArray()

Classes/PHPExcel/Style.php

@@ -395,19 +395,34 @@ public function applyFromArray($pStyles = null, $pAdvanced = true) {
 						break;
 				}
 
-				// clone each of the affected styles, apply the style arrray, and add the new styles to the workbook
 				$workbook = $this->getActiveSheet()->getParent();
+				$xfHashes = array();
+				if (count($oldXfIndexes) > 1) {
+					// compute hash codes once
+					foreach ($workbook->getCellXfCollection() as $cellXf) {
+						$xfHashes[$cellXf->getHashCode()] = $cellXf;
+					}
+				}
+				// clone each of the affected styles, apply the style arrray, and add the new styles to the workbook
 				foreach ($oldXfIndexes as $oldXfIndex => $dummy) {
 					$style = $workbook->getCellXfByIndex($oldXfIndex);
 					$newStyle = clone $style;
 					$newStyle->applyFromArray($pStyles);
+					$newHash = $newStyle->getHashCode();
+
+					if (count($oldXfIndexes) === 1) {
+						if ($existingStyle = $workbook->getCellXfByHashCode($newHash)) {
+							$xfHashes[$newHash] = $existingStyle;
+						}
+					}
 
-					if ($workbook->cellXfExists($newStyle)) {
+					if (isset($xfHashes[$newHash])) {
 						// there is already such cell Xf in our collection
-						$newXfIndexes[$oldXfIndex] = $existingStyle->getIndex();
+						$newXfIndexes[$oldXfIndex] = $xfHashes[$newHash]->getIndex();
 					} else {
 						// we don't have such a cell Xf, need to add
 						$workbook->addCellXf($newStyle);
+						$xfHashes[$newHash] = $newStyle;
 						$newXfIndexes[$oldXfIndex] = $newStyle->getIndex();
 					}
 				}

Examples/41applyFromArray.php

@@ -0,0 +1,92 @@
+<?php
+/** Error reporting */
+error_reporting(E_ALL);
+ini_set('display_errors', TRUE);
+ini_set('display_startup_errors', TRUE);
+date_default_timezone_set('Europe/London');
+
+define('EOL',(PHP_SAPI == 'cli') ? PHP_EOL : '<br />');
+
+date_default_timezone_set('Europe/London');
+
+/** Include PHPExcel */
+require_once '../Classes/PHPExcel.php';
+
+$ncols = 10;
+$nrows = 100;
+
+echo date('H:i:s') , " Create new PHPExcel object" , EOL;
+$objPHPExcel = new PHPExcel();
+$worksheet = $objPHPExcel->getActiveSheet();
+
+echo date('H:i:s') , " Create styles arrays" , EOL;
+$stylesArrays = array();
+for ($i = 0; $i < 10; $i++) {
+    $stylesArrays[] =
+		array(
+			'font' => array(
+				'size' => $i + 4
+				)
+			);
+}
+
+// add data
+echo date('H:i:s') , " Add data (begin)" , EOL;
+$t = microtime(true);
+for ($col = 0; $col < $ncols; $col++) {
+    for ($row = 0; $row < $nrows; $row++) {
+        $str = ($row + $col);
+        $coord = PHPExcel_Cell::stringFromColumnIndex($col) . ($row + 1);
+        $worksheet->setCellValue($coord, $str);
+    }
+}
+$d = microtime(true) - $t;
+echo date('H:i:s') , " Add data (end), time: " . round($d, 2) . " s", EOL;
+
+// applyFromArray
+echo date('H:i:s') , " applyFromArray styles (begin)" , EOL;
+$t = microtime(true);
+echo date('H:i:s') , " _cellXfCollection count before: " , count($objPHPExcel->getCellXfCollection()), EOL;
+for ($row = 0; $row < $nrows; $row++) {
+ 	$cellRange =
+		PHPExcel_Cell::stringFromColumnIndex(0) . ($row + 1) .
+ 		':' .
+		PHPExcel_Cell::stringFromColumnIndex($ncols - 1) . ($row + 1);
+	$styleArray =
+		array(
+			'font' => array(
+				'size' => $row % 10 + 4
+				)
+			);
+	$worksheet->getStyle($cellRange)->applyFromArray($stylesArrays[$row % count($stylesArrays)]);
+}
+echo date('H:i:s') , " _cellXfCollection count after size styles: " , count($objPHPExcel->getCellXfCollection()), EOL;
+$styleArray =
+	array(
+		'font' => array(
+			'name' => $worksheet->getDefaultStyle()->getFont()->getName(),
+			'size' => 20
+			)
+		);
+for ($col = 0; $col < $ncols; $col++) {
+	$cellRange =
+		PHPExcel_Cell::stringFromColumnIndex($col) . '1' .
+		':' .
+		PHPExcel_Cell::stringFromColumnIndex($col) . ($nrows);
+	$worksheet->getStyle($cellRange)->applyFromArray($styleArray);
+}
+echo date('H:i:s') , " _cellXfCollection count after new style: " , count($objPHPExcel->getCellXfCollection()), EOL;
+$d = microtime(true) - $t;
+echo date('H:i:s') , " applyFromArray styles (end), time: " . round($d, 2) . " s", EOL;
+
+// write file
+echo date('H:i:s') , " Write to Excel2007 format" , EOL;
+$objWriter = PHPExcel_IOFactory::createWriter($objPHPExcel, 'Excel2007');
+$objWriter->save(str_replace('.php', '.xlsx', __FILE__));
+echo date('H:i:s') , " File written to " , str_replace('.php', '.xlsx', pathinfo(__FILE__, PATHINFO_BASENAME)) , EOL;
+
+
+echo date('H:i:s') , " Peak memory usage: " , (memory_get_peak_usage(true) / 1024 / 1024) , " MB" , EOL;
+
+echo date('H:i:s') , " Done writing file" , EOL;
+echo 'File has been created in ' , getcwd() , EOL;