Skip to content
This repository was archived by the owner on Jan 2, 2019. It is now read-only.

Conversation

@DerDu
Copy link

@DerDu DerDu commented May 7, 2015

No description provided.

@DerDu
Copy link
Author

DerDu commented May 7, 2015

UTF-8 isn't? ..
No question, but now the function at least will try to respond somewhat to the error instead of nothing and just dying with 'highway-to-hell'-@.

This sanitizing method indeed needs a big refactoring on encoding detection and >>error handling<<

@DerDu
Copy link
Author

DerDu commented May 7, 2015

i know its more like quick'n dirty but it only triggers if the value is not already UTF-8 and most of the time the error occurs in combination with öäü߀ not correctly encoded as UTF-8 so WINDOWS-1252 can handle this quite well (including mac)
;-)

@MarkBaker
Copy link
Member

Related to PHPExcel PR #557 perhaps?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants