Skip to content

Add phpstan job to CI#31

Merged
Progi1984 merged 4 commits into
PHPOffice:developfrom
slayerfx:ci/phpstan-job
May 18, 2026
Merged

Add phpstan job to CI#31
Progi1984 merged 4 commits into
PHPOffice:developfrom
slayerfx:ci/phpstan-job

Conversation

@slayerfx
Copy link
Copy Markdown
Contributor

  • Add phpstan/phpstan ^1.10 as dev dependency
  • Add phpstan.neon.dist with level 1 configuration
  • Add phpstan job to GitHub Actions workflow (matrix PHP 7.3 → 8.5)
  • Fix inaccurate @return string PHPDoc on DocumentProperties::getCustomPropertyValue/Type() (now string|null, revealed by phpstan locally)
  • Fix PHP 8.4 implicit nullable parameter deprecations in XMLReader, PhpProject and IOFactory (now using ?Type $param = null, revealed by phpstan in CI on PHP 8.4+)

Comment thread src/PhpProject/DocumentProperties.php
Comment thread src/PhpProject/DocumentProperties.php
Copy link
Copy Markdown
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small fix

slayerfx and others added 2 commits May 18, 2026 14:44
Co-authored-by: Progi1984 <progi1984@gmail.com>
@Progi1984 Progi1984 merged commit 388d269 into PHPOffice:develop May 18, 2026
26 checks passed
@Progi1984 Progi1984 added this to the 0.3.0 milestone May 18, 2026
@slayerfx slayerfx deleted the ci/phpstan-job branch May 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants