Skip to content

Conversation

@Geolim4
Copy link
Member

@Geolim4 Geolim4 commented Feb 2, 2016

Global changes:

  • Added phpDoc Block comment on class/method/properties
  • Replaced var keyword with public
  • Defined non-existing visibility (public, protected, private)
  • Moved constructor to be first method position
  • Commented unused/emty if/else conditions
  • Improved return consistency, e.g: phpfastcache_xcache::driver_isExisting()
  • Removed aliases:
    • is_writeable() => is_writable()
  • Removed tab indentations (it hurt eyes so bad)
  • Removed silent operator (as per DeleteMulti() is not working properly (Not as defined in readme) #175):
    • sqlite.php
    • file_exists()
    • mkdir()
  • Ignored:
    • phpfastcache/_extensions/predis-1.0/*
    • phpfastcache/_extensions/SSDB.php

- Added phpDoc Block comment on class/method/properties
- Replaced **var** keyword with **public**
- Defined non-existing visibility (public, protected, private)
- Moved constructor to be first method position
- Commented unused/emty if/else conditions
- Improved return consistency, e.g: phpfastcache_xcache::driver_isExisting()

- Removed aliases:
 - is_writeable() => is_writable()

- Removed tab indentations (it hurt eyes so bad)

- Removed silent operator (as per #175):
 - sqlite.php
  - file_exists()
  - mkdir()

- Ignored:
 - phpfastcache/_extensions/predis-1.0/*
 - phpfastcache/_extensions/SSDB.php
# Conflicts:
#	phpfastcache/3.0.0/abstract.php
#	phpfastcache/3.0.0/drivers/files.php
#	phpfastcache/3.0.0/drivers/sqlite.php
#	phpfastcache/3.0.0/phpfastcache.php
@Geolim4
Copy link
Member Author

Geolim4 commented Feb 2, 2016

Warning, i resolved a conflict on some files, can you check if a don't forget anything during the merge ?
Thanks.

  • Conflicts:
    • phpfastcache/3.0.0/abstract.php
    • phpfastcache/3.0.0/drivers/files.php
    • phpfastcache/3.0.0/drivers/sqlite.php
    • phpfastcache/3.0.0/phpfastcache.php

@Geolim4
Copy link
Member Author

Geolim4 commented Feb 2, 2016

Related issue: #177

khoaofgod added a commit that referenced this pull request Feb 2, 2016
@khoaofgod khoaofgod merged commit 26f5527 into PHPSocialNetwork:final Feb 2, 2016
@Geolim4
Copy link
Member Author

Geolim4 commented Feb 2, 2016

Already merged ? Oo
So fast !

@khoaofgod
Copy link
Member

I trust you, hahahaha

On Mon, Feb 1, 2016 at 5:52 PM, Georges notifications@github.com wrote:

Already merged ? Oo
So fast !


Reply to this email directly or view it on GitHub
https://github.com/khoaofgod/phpfastcache/pull/181#issuecomment-178307716
.

@khoaofgod
Copy link
Member

it merged, but it's not a release yet. ^_^

On Mon, Feb 1, 2016 at 5:52 PM, Banh Mi DSLR101 khoaofgod@gmail.com wrote:

I trust you, hahahaha

On Mon, Feb 1, 2016 at 5:52 PM, Georges notifications@github.com wrote:

Already merged ? Oo
So fast !


Reply to this email directly or view it on GitHub
https://github.com/khoaofgod/phpfastcache/pull/181#issuecomment-178307716
.

@Geolim4
Copy link
Member Author

Geolim4 commented Feb 2, 2016

Ok :)

@khoaofgod
Copy link
Member

I will test it after work today or tmr before I draft a new release on this commit.
Thanks again for help me on this, I was overload from last summer.

@Geolim4
Copy link
Member Author

Geolim4 commented Feb 2, 2016

You're welcome, i love readable and well-commented code :))

@Geolim4 Geolim4 deleted the issue-177 branch February 4, 2016 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants