-
-
Notifications
You must be signed in to change notification settings - Fork 451
Issue 177 #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 177 #181
Conversation
- Added phpDoc Block comment on class/method/properties - Replaced **var** keyword with **public** - Defined non-existing visibility (public, protected, private) - Moved constructor to be first method position - Commented unused/emty if/else conditions - Improved return consistency, e.g: phpfastcache_xcache::driver_isExisting() - Removed aliases: - is_writeable() => is_writable() - Removed tab indentations (it hurt eyes so bad) - Removed silent operator (as per #175): - sqlite.php - file_exists() - mkdir() - Ignored: - phpfastcache/_extensions/predis-1.0/* - phpfastcache/_extensions/SSDB.php
# Conflicts: # phpfastcache/3.0.0/abstract.php # phpfastcache/3.0.0/drivers/files.php # phpfastcache/3.0.0/drivers/sqlite.php # phpfastcache/3.0.0/phpfastcache.php
|
Warning, i resolved a conflict on some files, can you check if a don't forget anything during the merge ?
|
|
Related issue: #177 |
|
Already merged ? Oo |
|
I trust you, hahahaha On Mon, Feb 1, 2016 at 5:52 PM, Georges notifications@github.com wrote:
|
|
it merged, but it's not a release yet. ^_^ On Mon, Feb 1, 2016 at 5:52 PM, Banh Mi DSLR101 khoaofgod@gmail.com wrote:
|
|
Ok :) |
|
I will test it after work today or tmr before I draft a new release on this commit. |
|
You're welcome, i love readable and well-commented code :)) |
Global changes: