Skip to content

Conversation

@AntiEngineer
Copy link
Contributor

Proposed changes

Removes deprecation notice.

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

@AntiEngineer
Copy link
Contributor Author

There you go @Geolim4.

@AntiEngineer
Copy link
Contributor Author

Side note: breaks PHP 7.0 since looks like the method isn't there.

@AntiEngineer
Copy link
Contributor Author

There it is.

In versions where getName isn't present, it'll fall back to __toString.

Cheers.

@Geolim4
Copy link
Member

Geolim4 commented Aug 8, 2020

Side note: breaks PHP 7.0 since looks like the method isn't there.

Hehe that's why the Travis CI is here ;)

Thanks, I'm reviewing this PR !

@Geolim4 Geolim4 self-assigned this Aug 8, 2020
@Geolim4 Geolim4 merged commit eb40fea into PHPSocialNetwork:v7 Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants