Skip to content

"Find all references" and rename action for @property/@method in PHPDoc#115

Merged
AJenbo merged 1 commit into
PHPantom-dev:mainfrom
AbyssWaIker:rename_and_find_references_to_phpdoc
May 9, 2026
Merged

"Find all references" and rename action for @property/@method in PHPDoc#115
AJenbo merged 1 commit into
PHPantom-dev:mainfrom
AbyssWaIker:rename_and_find_references_to_phpdoc

Conversation

@AbyssWaIker
Copy link
Copy Markdown
Contributor

Most existing Laravel projects are declaring properties like this (same for methods in facades)

namespace App\Models;

use Carbon\Carbon;

/**
* @property int $id
* @property string $email
* @property Carbon $created_at
*/
class User extends Model
{
//...
}

I am used to ctrl+clicking on properties like this to find all references but phpantom did not emit MemberDeclaration on those spans for this (and rename action which I'm also often using in the same place)

@AJenbo AJenbo force-pushed the rename_and_find_references_to_phpdoc branch from a1a578d to 2e3c394 Compare May 9, 2026 17:51
@AJenbo AJenbo force-pushed the rename_and_find_references_to_phpdoc branch from 2e3c394 to b1703a4 Compare May 9, 2026 18:31
@AJenbo AJenbo merged commit 2a7e335 into PHPantom-dev:main May 9, 2026
7 checks passed
@AbyssWaIker
Copy link
Copy Markdown
Contributor Author

AbyssWaIker commented May 9, 2026

And thanks for all the incredible work you've done.

It's inspiring

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.54545% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.83%. Comparing base (479a666) to head (b1703a4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/symbol_map/docblock.rs 93.47% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   86.82%   86.83%   +0.01%     
==========================================
  Files         170      170              
  Lines      108237   108345     +108     
==========================================
+ Hits        93973    94083     +110     
+ Misses      14264    14262       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AJenbo
Copy link
Copy Markdown
Collaborator

AJenbo commented May 9, 2026

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants