Compilation optimization for modern CPU#137
Open
DarkGhostHunter wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following fixes #132. It adds two things:
v2,v3, andv4builds for all x86-64 builds: Windows, Linux and (Intel) Mac¹.v1(default) builds.x86-64-v1ornativeas target CPU.v2: (as-is)v3:modernv4:avx512CARGO_PROFILE_RELEASE_OPT_LEVEL="3": Max optimisations for execution, greater compilation timeCARGO_PROFILE_RELEASE_LTO="thin": Aggressive global optimisation, greater compilation time, less risks of OOM.The Zed Editor extension will still download the
v2builds by default on x86-64, since it's not suffixed.It would be great that it could detect the required flags to download the most optimised binary for the system. I believe this can be done by probing the CPU for the SIMD flags:
AI aided in this block, while trying to check how would be the logic. I guess it will depend on calling shell commands for CPU support.
1: Intel Macs spawn from Nehalem (2008), Haswell (2013), and Skylake-X/Xeon and Ice Lake (2017).