fix(rename): support renaming variables inside deeply nested arrows and closures#145
Open
calebdw wants to merge 1 commit into
Open
fix(rename): support renaming variables inside deeply nested arrows and closures#145calebdw wants to merge 1 commit into
calebdw wants to merge 1 commit into
Conversation
…nd closures
- Add upward ancestor walk before collect_capture_scopes so rename/refs
work when invoked from deep inside fn()=>fn()=> $var or mixed
function() use() { ... } closures.
- Switch has_usage to lexical byte-range containment so intermediate
arrow scopes in nesting chains are recognized.
- Add tests covering the reported case, deeply nested closures with use(),
mixed closure+arrow, and both "from declaration" and "from usage" directions.
- Restore and update internal comments for accuracy.
Fixes PHPantom-dev#143
calebdw
force-pushed
the
calebdw/push-ksxkmtplqnzu
branch
from
853b111 to
71924a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fn () => fn () => $var) and mixedfunction () use ($var)closures.collect_capture_scopesonly walked downward and used innermost-scope matching for "has usage".ClosureCapturesites) + lexical byte-range check forhas_usage.use(), mixed nesting, and rename from both declaration and deep usage sites.Fixes #143
Testing
cargo check+cargo clippy --tests -- -D warningsclean