fix(diagnostics): resolve callable return type for call-result invocations#189
Open
calebdw wants to merge 2 commits into
Open
fix(diagnostics): resolve callable return type for call-result invocations#189calebdw wants to merge 2 commits into
calebdw wants to merge 2 commits into
Conversation
calebdw
force-pushed
the
calebdw/push-oqxkuqnpsozq
branch
from
e10807d to
7e8284e
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
calebdw
force-pushed
the
calebdw/push-oqxkuqnpsozq
branch
2 times, most recently
from
23ac09e to
4a4e9bb
Compare
…tions
When a function/method returns a callable type and the return value is
immediately invoked — e.g. `makeCallable('1', '2')('test')` — the LSP
previously used the outer function's parameter signature for the inner
invocation. This caused:
- False argument_count_mismatch diagnostics (expected 2 args, got 1)
- Wrong inlay hint parameter names ($a instead of $c)
The fix intercepts CallExpr resolution: after resolving the inner
callee, check if its return type is callable. If so, use the callable's
parameter signature instead of the callee's own params.
Handles:
- Typed callable: `callable(string): string` — extracts params
- Bare callable/Closure: flags accepts_any_args to suppress diagnostics
- Union types and nullable: recursively checks branches
Closes PHPantom-dev#184
Signed-off-by: Anders Jenbo <anders@jenbo.dk>
calebdw
force-pushed
the
calebdw/push-oqxkuqnpsozq
branch
from
885d442 to
8fc3672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a function/method returns a callable type and the return value is immediately invoked — e.g.
makeCallable('1', '2')('test')— the LSP previously used the outer function's parameter signature for the inner invocation. This caused:The fix intercepts CallExpr resolution: after resolving the inner callee, check if its return type is callable. If so, use the callable's parameter signature instead of the callee's own params.
Handles:
callable(string): string— extracts paramsCloses #184