feat(docblock): recognize @phpstan-sealed tag for class references#190
Open
calebdw wants to merge 1 commit into
Open
feat(docblock): recognize @phpstan-sealed tag for class references#190calebdw wants to merge 1 commit into
calebdw wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
calebdw
force-pushed
the
calebdw/push-rvvnyvzrnmum
branch
from
d5405c5 to
ec870ce
Compare
Add support for the `@phpstan-sealed FooClass|BarClass` PHPStan tag so that class names referenced in it are treated as type references. This prevents false 'unused import' diagnostics when a use statement is only referenced via `@phpstan-sealed`. Changes: - symbol_map/docblock.rs: add "phpstan-sealed" to TYPE_FIRST_OTHER_NAMES so the tag's description is parsed as a type and emits ClassReference spans - diagnostics/unused_imports.rs: add "@phpstan-sealed" to PHPDOC_TYPE_TAGS so the content safety-net recognizes it - completion/phpdoc/context.rs: add "phpstan-sealed" to type-first tags so docblock type completion works after the tag - completion/phpdoc/mod.rs: add TagDef for @phpstan-sealed autocomplete Closes PHPantom-dev#185
calebdw
force-pushed
the
calebdw/push-rvvnyvzrnmum
branch
from
ec870ce to
0eb1972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
@phpstan-sealed FooClass|BarClassPHPStan tag so that class names referenced in it are treated as type references. This prevents false 'unused import' diagnostics when a use statement is only referenced via@phpstan-sealed.Changes:
Closes #185