Add support for signature help for new self, new static and new parent expressions#51
Merged
Merged
Conversation
parent` expressions
AJenbo
reviewed
Mar 29, 2026
Collaborator
AJenbo
left a comment
AJenbo
left a comment
There was a problem hiding this comment.
Thank, I think rebasing on main should fix the CI issues.
AJenbo
reviewed
Mar 29, 2026
AJenbo
reviewed
Mar 29, 2026
AJenbo
reviewed
Mar 29, 2026
Contributor
Author
|
Thanks for the review, I think I have addressed all the requests changes, let me know if you want me to make more changes! |
AJenbo
previously approved these changes
Mar 29, 2026
Collaborator
|
Thanks you for you helping in make the project better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I'm new to the codebase so might choose the wrong paths to fix things, but this PR fixes the following 2 issues that are related to each other:
new self,new staticandnew parentexpressions was not working.new self,new staticandnew parentexpression arguments was not working.Let me know if you want me to make any changes, so the code is maybe a bit more inline with the other part of the codebase.