fix: restrict no-commit-to-branch to pre-commit stage only#2
Merged
Conversation
Running this hook at pre-push stage is architecturally wrong: by push time the commit already exists locally, so blocking the push doesn't undo anything. The guard only makes sense at commit time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
no-commit-to-branchat pre-push time is architecturally wrong. By the time a push runs, the commit already exists locally — blocking the push doesn't undo it, it just prevents delivery. The hook only makes sense at the commit stage where it can actually stop the commit from being created.This was surfaced when doing the fast-forward merge of develop → main: the pre-push hook fired and blocked the push because the current branch was
main.