Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bstaber
approved these changes
Mar 2, 2026
Comment on lines
+27
to
+35
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install ruff | ||
| uv pip install --system ruff | ||
|
|
||
| - name: Ruff lint | ||
| run: ruff check . | ||
| run: uv run ruff check . | ||
|
|
||
| - name: Ruff format check | ||
| run: ruff format --check . | ||
| run: uv run ruff format --check . |
Contributor
There was a problem hiding this comment.
I think you can either do uv sync --dev instead of uv pip install --system ruff, or simply use uvx ruff check . and uvx ruff format --check . without having to install anything because ruff is provided by uvx
| id: verify-version | ||
| run: | | ||
| pip install . | ||
| uv pip install --system . |
Contributor
There was a problem hiding this comment.
I think that since you uv sync before, you don't need this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! Please make sure your PR title and content follow the guidelines.
Leave this checklist below in your PR description and tick the corresponding boxes.
Checklist
Typing enforcedTests and Example updates