Skip to content

🐛 (storage/common/preprocessor) Fix: make constant_features split-dependant#330

Merged
casenave merged 2 commits intomainfrom
fix/constant_split
Mar 8, 2026
Merged

🐛 (storage/common/preprocessor) Fix: make constant_features split-dependant#330
casenave merged 2 commits intomainfrom
fix/constant_split

Conversation

@casenave
Copy link
Copy Markdown
Member

@casenave casenave commented Mar 8, 2026

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

Closes #329

@casenave casenave requested a review from a team as a code owner March 8, 2026 07:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@casenave casenave changed the title 🐛 Fix/constant split 🐛 (storage/common/preprocessor) Fix: make constant_features split-dependant Mar 8, 2026
@casenave casenave marked this pull request as draft March 8, 2026 07:36
@casenave casenave marked this pull request as ready for review March 8, 2026 10:20
@casenave
Copy link
Copy Markdown
Member Author

casenave commented Mar 8, 2026

I'm merging since it will not affect reading existing datasets, but we still have to regenerate our initial 6 datasets anyway (PointData -> VertexFields, etc...). Without this PR, generating datasets with, for instance no outputs on the testing set, leads to a crash

@casenave casenave merged commit 1fc5070 into main Mar 8, 2026
22 checks passed
@casenave casenave deleted the fix/constant_split branch March 8, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 storage: write_to_disk

1 participant