Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bstaber
approved these changes
Mar 25, 2026
| def _extract_ids_from_partial( | ||
| gen: partial, | ||
| split_name: str, | ||
| ) -> tuple[Any, Callable, tuple, dict]: |
Contributor
There was a problem hiding this comment.
difficile à comprendre mais ça a l'air d'être correct avec ce que la fonction produit
| gen_kwargs: dict[str, dict[str, Any]] = {} | ||
|
|
||
| for split_name, gen in generators.items(): | ||
| if not isinstance(gen, partial): |
Contributor
There was a problem hiding this comment.
I'm wondering if after this we could make it even simpler to avoid making the user import functools.partial etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Related issues
Closes #353