Skip to content

🎉 Add dataset viewer#384

Merged
casenave merged 33 commits into
mainfrom
viewer
May 21, 2026
Merged

🎉 Add dataset viewer#384
casenave merged 33 commits into
mainfrom
viewer

Conversation

@casenave
Copy link
Copy Markdown
Member

@casenave casenave commented Apr 29, 2026

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

Comment thread tests/viewer/test_trame_server.py Fixed
Comment thread tests/viewer/test_trame_server.py Fixed
Comment thread src/plaid/viewer/trame_app/server.py Fixed
Comment thread src/plaid/viewer/trame_app/server.py Fixed
Comment thread tests/viewer/test_cache.py Fixed
Comment thread src/plaid/viewer/cache.py Fixed
Comment thread src/plaid/viewer/trame_app/server.py Fixed
Comment thread src/plaid/viewer/trame_app/server.py Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

casenave and others added 3 commits April 29, 2026 21:11
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Comment thread src/plaid/viewer/trame_app/server.py Fixed
@casenave casenave marked this pull request as ready for review April 30, 2026 05:30
@casenave casenave requested a review from a team as a code owner April 30, 2026 05:30
@casenave
Copy link
Copy Markdown
Member Author

@bstaber @fbordeu ready to review

devnull_fd = os.open(os.devnull, os.O_WRONLY)
os.dup2(devnull_fd, 2)
os.close(devnull_fd)
_C_STDERR_REROUTED = True
# Some VTK builds expose ``vtkLogger`` but not this verbosity API.
# Ignore to keep compatibility and continue without hard failure.
pass
_VTK_LOG_ROUTER_INSTALLED = True
Comment thread docs/source/core_concepts/viewer.md
Comment thread docs/source/core_concepts/viewer.md Outdated
Comment thread docs/source/core_concepts/viewer.md
Copy link
Copy Markdown
Contributor

@tdaniel06 tdaniel06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf comments

@casenave
Copy link
Copy Markdown
Member Author

@tdaniel06 on en discute demain, merci !

@tdaniel06
Copy link
Copy Markdown
Contributor

Feedbacks regarding the user interface: I was a little confused when seeing the Base/Field selection area, which was empty before scrolling down to the "Features" section to load desired features. The "Features" section seemed redundant with the Field selection menu at first.
Suggestion: rename the "Features" section by something like "Pre-select browsable features"

@casenave
Copy link
Copy Markdown
Member Author

Feedbacks regarding the user interface: I was a little confused when seeing the Base/Field selection area, which was empty before scrolling down to the "Features" section to load desired features. The "Features" section seemed redundant with the Field selection menu at first. Suggestion: rename the "Features" section by something like "Pre-select browsable features"

Thanks for the suggestion, it's done:
image

@casenave
Copy link
Copy Markdown
Member Author

@xroynard ready to merge !

@fbordeu
Copy link
Copy Markdown
Collaborator

fbordeu commented May 13, 2026

Ok, I'm going to clone this and port it to the ProtoV1

@fbordeu
Copy link
Copy Markdown
Collaborator

fbordeu commented May 13, 2026

Ok, I'm going to clone this and port it to the ProtoV1

waiting for this PR to be merged. Then I'm merging the port to ProtoV1
#391

@casenave casenave merged commit fb3aea1 into main May 21, 2026
22 checks passed
@casenave casenave deleted the viewer branch May 21, 2026 17:48
@casenave casenave mentioned this pull request May 21, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants