Skip to content

🎉 Binder support#392

Merged
fbordeu merged 8 commits into
ProtoV1from
BinderSupport
May 19, 2026
Merged

🎉 Binder support#392
fbordeu merged 8 commits into
ProtoV1from
BinderSupport

Conversation

@fbordeu
Copy link
Copy Markdown
Collaborator

@fbordeu fbordeu commented May 14, 2026

Thanks for contributing! Please make sure your PR title and content follow the guidelines.
Leave this checklist below in your PR description and tick the corresponding boxes.

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

✅ PR Title Format

Your PR title must start with one of the following emojis to indicate the type of change:

  • 🐛 Bug fix
  • 📄 Documentation
  • 🎉 New feature or initial commit
  • 🚀 Performance or deployment
  • ♻️ Refactor or cleanup
  • 📦 Packaging or dependency management (e.g., pyproject.toml, conda, Poetry, pre-commit)

Example:
🎉 Add MMD-based split method


📋 Description (optional)

Please explain what your PR does:

  • What problem does it solve?
  • Any breaking changes?
  • How was it tested?

🔗 Related issues (optional)

Closes #___

@fbordeu fbordeu added this to the version 1.0.0 milestone May 14, 2026
@fbordeu fbordeu requested a review from a team as a code owner May 14, 2026 06:02
@fbordeu fbordeu changed the base branch from main to ProtoV1 May 14, 2026 06:02
@fbordeu fbordeu marked this pull request as draft May 14, 2026 06:03
@fbordeu
Copy link
Copy Markdown
Collaborator Author

fbordeu commented May 14, 2026

image

@fbordeu fbordeu modified the milestones: version 1.0.0, version 1.1.0 May 14, 2026
@fbordeu
Copy link
Copy Markdown
Collaborator Author

fbordeu commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fbordeu
Copy link
Copy Markdown
Collaborator Author

fbordeu commented May 19, 2026

This is working as intended,
The only problem is the limited capacity of the binder instance. no suitable for downloading hf dataset, so finally really limited for the exploration of the library.

you can try it here:
https://mybinder.org/v2/gh/PLAID-lib/plaid/BinderSupport?urlpath=%2Fdoc%2Ftree%2Fexamples%2Fproblem_definition_example.py

if ok, I can merge it to ProtoV1.

@fbordeu fbordeu modified the milestones: version 1.1.0, version 1.0.0 May 19, 2026
@fbordeu fbordeu marked this pull request as ready for review May 19, 2026 08:14
@fbordeu fbordeu merged commit 27e95ed into ProtoV1 May 19, 2026
17 checks passed
@fbordeu fbordeu deleted the BinderSupport branch May 19, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant