Skip to content

🎉 New feature: Integration point support (basic)#400

Merged
fbordeu merged 5 commits into
ProtoV1from
IPSupport
May 20, 2026
Merged

🎉 New feature: Integration point support (basic)#400
fbordeu merged 5 commits into
ProtoV1from
IPSupport

Conversation

@fbordeu
Copy link
Copy Markdown
Collaborator

@fbordeu fbordeu commented May 20, 2026

Thanks for contributing! Please make sure your PR title and content follow the guidelines.
Leave this checklist below in your PR description and tick the corresponding boxes.

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

✅ PR Title Format

Your PR title must start with one of the following emojis to indicate the type of change:

  • 🐛 Bug fix
  • 📄 Documentation
  • 🎉 New feature or initial commit
  • 🚀 Performance or deployment
  • ♻️ Refactor or cleanup
  • 📦 Packaging or dependency management (e.g., pyproject.toml, conda, Poetry, pre-commit)

Example:
🎉 Add MMD-based split method


📋 Description (optional)

Please explain what your PR does:

  • What problem does it solve?
  • Any breaking changes?
  • How was it tested?

🔗 Related issues (optional)

Closes #___

@fbordeu fbordeu requested a review from a team as a code owner May 20, 2026 02:48
@fbordeu fbordeu changed the base branch from main to ProtoV1 May 20, 2026 02:49
Comment thread src/plaid/containers/features.py Outdated
if field_name not in ["GridLocation","ItgRules","gridlocation","ItgPointStartOffset", "Ids","Path"]:
names.append(field_name)

solution_paths = CGU.getPathsByTypeSet(search_node, [CGK.FlowSolution_t])
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/plaid/containers/features.py 80.00% 4 Missing ⚠️
src/plaid/storage/common/preprocessor.py 50.00% 2 Missing ⚠️
src/plaid/utils/cgns_helper.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@fbordeu fbordeu merged commit 3fa23c2 into ProtoV1 May 20, 2026
16 of 17 checks passed
@fbordeu fbordeu deleted the IPSupport branch May 20, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant