Skip to content

docs(cfc): Architecture#1007

Merged
volsa merged 14 commits intomasterfrom
cfc-documentation
Nov 20, 2023
Merged

docs(cfc): Architecture#1007
volsa merged 14 commits intomasterfrom
cfc-documentation

Conversation

@volsa
Copy link
Copy Markdown
Member

@volsa volsa commented Nov 7, 2023

Open questions before merging:

  • Should we describe how each CFC element is implemented (e.g. we currently only give examples for blocks, variables)?
    • Could be multiple sub-sections
  • Can we assume the user knows CFC and its concepts, e.g. local and execution-ids?

Done in pairing with @mhasel

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77cd41e) 95.76% compared to head (87877b8) 95.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   95.76%   95.79%   +0.03%     
==========================================
  Files         153      153              
  Lines       42496    42496              
==========================================
+ Hits        40695    40708      +13     
+ Misses       1801     1788      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@volsa volsa changed the title docs(cfc): Documentation docs(cfc): Architecture Nov 7, 2023
volsa and others added 4 commits November 8, 2023 12:22
Co-authored-by: Michael <mhasel@users.noreply.github.com>
@volsa volsa requested review from ghaith and riederm November 8, 2023 13:57
@volsa volsa marked this pull request as ready for review November 9, 2023 09:04
remove todo, insert link
@TheColonel2688
Copy link
Copy Markdown

I just want to pop in and say I really like an appreciate you guys creating docs that explain the architecture. Not only is it helpful for rusty specifically but also for understanding PLC compilers in general.

@volsa volsa merged commit a26aa0b into master Nov 20, 2023
@volsa volsa deleted the cfc-documentation branch November 20, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants