fix: Fetch virtual table dependencies in resolver #1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when visiting the virtual-table pointer of a class or function block,
the resolver added a dependency on the intrinsic `VOID` type but not on the
concrete `__vtable_*` struct and its members. Codegen then failed with
“unknown type” when expanding opaque types that reference vtable members.
This commit fixes that, such that the members of the virtual table are fetched and
added as dependencies in the resolver module.
A minimal reproducible example would be
```
// file: main.st
FUNCTION main
VAR
baseInstance: base;
baseRef: POINTER TO base;
END_VAR
baseRef := ADR(baseInstance);
baseRef^.foo();
END_FUNCTION
// file: base.st
FUNCTION_BLOCK base
METHOD foo
printf('base::foo$N');
END_METHOD
END_FUNCTION_BLOCK
```
ghaith
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when visiting the virtual-table pointer of a class or function block, the resolver added a dependency on the intrinsic
VOIDtype but not on the concrete__vtable_*struct and its members. Codegen then failed with “unknown type” when expanding opaque types that reference vtable members.This commit fixes that, such that the members of the virtual table are fetched and added as dependencies in the resolver module.
A minimal reproducible example would be