Skip to content

XML deserializer & parser#883

Merged
ghaith merged 127 commits intomasterfrom
xml-parser
Aug 23, 2023
Merged

XML deserializer & parser#883
ghaith merged 127 commits intomasterfrom
xml-parser

Conversation

@mhasel
Copy link
Copy Markdown
Member

@mhasel mhasel commented Jul 3, 2023

In order to make the code-review process more easily digestible, the CFC feature PR has been split into multiple parts. At first, only AST elements that are compatible with existing Structured Text - AST are introduced.

In this PR:

  • XML peekable reader
  • deserializer & serializer
  • model-to-AST transformer for assignments and call-statements

Co-authored by @volsa

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2023

Codecov Report

Patch coverage: 82.52% and project coverage change: -0.40% ⚠️

Comparison is base (f7fbc52) 95.96% compared to head (029f6fe) 95.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   95.96%   95.56%   -0.40%     
==========================================
  Files         128      150      +22     
  Lines       38781    39969    +1188     
==========================================
+ Hits        37217    38198     +981     
- Misses       1564     1771     +207     
Files Changed Coverage Δ
compiler/plc_derive/src/lib.rs 100.00% <ø> (ø)
compiler/plc_derive/tests/rusty_derive_tests.rs 100.00% <ø> (ø)
compiler/plc_xml/src/model/action.rs 0.00% <0.00%> (ø)
compiler/plc_xml/src/model/connector.rs 0.00% <0.00%> (ø)
compiler/plc_xml/src/model/control.rs 0.00% <0.00%> (ø)
compiler/plc_xml/src/xml_parser/action.rs 0.00% <0.00%> (ø)
src/lexer.rs 97.57% <ø> (ø)
src/parser.rs 97.48% <ø> (ø)
src/validation.rs 94.93% <ø> (ø)
compiler/plc_xml/src/error.rs 29.16% <29.16%> (ø)
... and 20 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhasel mhasel marked this pull request as ready for review July 4, 2023 13:21
@mhasel mhasel requested review from ghaith and riederm July 4, 2023 13:21
Copy link
Copy Markdown
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this behind a feature flag for now? (fbd or cfc)

Comment thread .vscode/settings.json Outdated
@ghaith ghaith merged commit 98fe5e0 into master Aug 23, 2023
@ghaith ghaith deleted the xml-parser branch August 23, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants