Conversation
Co-authored-by: Michael <mhasel@users.noreply.github.com>
Co-authored-by: Michael <mhasel@users.noreply.github.com>
Co-authored-by: Michael <mhasel@users.noreply.github.com>
Co-authored-by: Michael <mhasel@users.noreply.github.com>
moves extract_attributes to reader updated struct fields to be in line with .xsd file
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #883 +/- ##
==========================================
- Coverage 95.96% 95.56% -0.40%
==========================================
Files 128 150 +22
Lines 38781 39969 +1188
==========================================
+ Hits 37217 38198 +981
- Misses 1564 1771 +207
☔ View full report in Codecov by Sentry. |
ghaith
reviewed
Aug 4, 2023
Collaborator
ghaith
left a comment
There was a problem hiding this comment.
Could we add this behind a feature flag for now? (fbd or cfc)
volsa
reviewed
Aug 4, 2023
ghaith
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make the code-review process more easily digestible, the CFC feature PR has been split into multiple parts. At first, only AST elements that are compatible with existing Structured Text - AST are introduced.
In this PR:
Co-authored by @volsa