Skip to content

Fix linking issue on macOS#893

Merged
volsa merged 3 commits intomasterfrom
__macos_linker
Jul 12, 2023
Merged

Fix linking issue on macOS#893
volsa merged 3 commits intomasterfrom
__macos_linker

Conversation

@volsa
Copy link
Copy Markdown
Member

@volsa volsa commented Jul 7, 2023

Running cargo b -p iec61131std previously returned linking errors on macOS which this PR fixes by using clang as well as the -r flag instead of --relocatable. Both these flags should be equivalent although the latter isn't recognized on clang.

EDIT: Unrelated to the linking issue, I've also deduplicated some linker code by using a trait default implementation

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2023

Codecov Report

Patch coverage: 96.07% and project coverage change: +0.06 🎉

Comparison is base (17d040c) 96.06% compared to head (cfae1ad) 96.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   96.06%   96.12%   +0.06%     
==========================================
  Files         116      116              
  Lines       38410    38412       +2     
==========================================
+ Hits        36898    36923      +25     
+ Misses       1512     1489      -23     
Impacted Files Coverage Δ
src/lib.rs 72.22% <0.00%> (+2.88%) ⬆️
src/linker.rs 85.31% <95.83%> (+7.53%) ⬆️
src/diagnostics.rs 80.11% <100.00%> (+0.13%) ⬆️
src/parser.rs 97.30% <100.00%> (+<0.01%) ⬆️
src/typesystem.rs 96.51% <100.00%> (+0.01%) ⬆️
src/validation/statement.rs 92.10% <100.00%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@volsa volsa requested a review from ghaith July 7, 2023 11:30
@volsa volsa merged commit 6712474 into master Jul 12, 2023
@volsa volsa deleted the __macos_linker branch July 12, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants