Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
==========================================
+ Coverage 96.06% 96.12% +0.06%
==========================================
Files 116 116
Lines 38410 38412 +2
==========================================
+ Hits 36898 36923 +25
+ Misses 1512 1489 -23
☔ View full report in Codecov by Sentry. |
ghaith
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
cargo b -p iec61131stdpreviously returned linking errors on macOS which this PR fixes by using clang as well as the-rflag instead of--relocatable. Both these flags should be equivalent although the latter isn't recognized on clang.EDIT: Unrelated to the linking issue, I've also deduplicated some linker code by using a trait default implementation