Skip to content

Remove debug feature flag#901

Merged
volsa merged 5 commits intomasterfrom
__debug
Jul 13, 2023
Merged

Remove debug feature flag#901
volsa merged 5 commits intomasterfrom
__debug

Conversation

@volsa
Copy link
Copy Markdown
Member

@volsa volsa commented Jul 12, 2023

Removes all occurrences of [cfg(feature = "debug")] with log::debug
Resolves #898

@volsa volsa requested review from ghaith and mhasel July 12, 2023 11:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 12, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.02 ⚠️

Comparison is base (bfb7463) 96.11% compared to head (cc87c70) 96.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   96.11%   96.09%   -0.02%     
==========================================
  Files         116      116              
  Lines       38412    38392      -20     
==========================================
- Hits        36918    36892      -26     
- Misses       1494     1500       +6     
Impacted Files Coverage Δ
compiler/plc_driver/src/lib.rs 92.68% <66.66%> (ø)
libs/stdlib/tests/common/mod.rs 100.00% <100.00%> (ø)
src/codegen.rs 95.66% <100.00%> (-0.28%) ⬇️
src/linker.rs 85.10% <100.00%> (-0.21%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@volsa volsa merged commit 9b89598 into master Jul 13, 2023
@volsa volsa deleted the __debug branch July 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace debug feature flag with log::debug

2 participants