Adding new class for wrapping typical ADVI workflow#16
Draft
mcnaughtonadm wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
The line: Line 72 in cfe80dc should be rewritten to accept any type of |
Member
|
This is a great start! Let's generalize this a bit so that we can swap out the variational inference method. Let's also create similar classes for upstream preprocessing and downstream post-processing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will address #15 .
To be able to utilize a template JSON file with the
emllcode. It is necessary to break the components needed to run the ADVI into their own methods. Here we break the scripts present in therun_hackett_inference.pyinto a separate class calledBMCA(can be renamed to whatever, this is just a placeholder) that loads thecobramodel, along with the paths to the various data sources.