Skip to content

Adding new class for wrapping typical ADVI workflow#16

Draft
mcnaughtonadm wants to merge 1 commit into
masterfrom
hackett_methods
Draft

Adding new class for wrapping typical ADVI workflow#16
mcnaughtonadm wants to merge 1 commit into
masterfrom
hackett_methods

Conversation

@mcnaughtonadm
Copy link
Copy Markdown
Collaborator

This PR will address #15 .

To be able to utilize a template JSON file with the emll code. It is necessary to break the components needed to run the ADVI into their own methods. Here we break the scripts present in the run_hackett_inference.py into a separate class called BMCA (can be renamed to whatever, this is just a placeholder) that loads the cobra model, along with the paths to the various data sources.

@mcnaughtonadm mcnaughtonadm linked an issue Nov 30, 2023 that may be closed by this pull request
@mcnaughtonadm mcnaughtonadm self-assigned this Nov 30, 2023
@mcnaughtonadm mcnaughtonadm added the enhancement New feature or request label Nov 30, 2023
@mcnaughtonadm
Copy link
Copy Markdown
Collaborator Author

The line:

self.model = cobra.io.load_yaml_model(model_path)

should be rewritten to accept any type of cobra model input.

@djinnome
Copy link
Copy Markdown
Member

This is a great start! Let's generalize this a bit so that we can swap out the variational inference method.

Let's also create similar classes for upstream preprocessing and downstream post-processing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Break run_hackett_inference.py into methods

2 participants