Adding df3, density_file query range support to max_extent. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables users to determine the x,y,z ranges, returned as a vector, for density_file based pigments matching a similar function for image maps.
source/parser/parser_expressions.cpp
Outdated
| END_CASE | ||
|
|
||
| // JN2007: Image map dimensions: | ||
| CASE (PIGMENT_ID_TOKEN) |
Contributor
There was a problem hiding this comment.
Currently this only works for pigment, but I think we also want it to work with density, so I suggest to replace the above with CASE2 (PIGMENT_ID_TOKEN, DENSITY_ID_TOKEN).
Adding normal and density support to the existing pigment support for image and density_file range determination with max_extent. Also re-worked the conditionals as requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables users to determine the x,y,z ranges, returned as a vector, for
density_file based pigments matching a similar function for image maps.