[feature] Update behavior for Windows Store installations #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements updated behavior for Windows Store installations by allowing update search while disabling auto-update functionality. The key changes include exposing a reusable extension method to detect Windows Store installations and updating the corresponding test behavior.
- Extracts Windows Store detection logic into a reusable extension method
- Allows update search for Windows Store installations while disabling auto-update
- Updates tests to verify that Windows Store installations can search for updates
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ByteSync.Client/Helpers/EnvironmentServiceExtensions.cs | New extension method for detecting Windows Store installations |
| src/ByteSync.Client/Services/Updates/SearchUpdateService.cs | Removes early return for Windows Store installations, allowing update search |
| src/ByteSync.Client/ViewModels/Headers/UpdateDetailsViewModel.cs | Disables auto-update capability for Windows Store installations |
| tests/ByteSync.Client.Tests/Services/Communications/SearchUpdateServiceTests.cs | Updates test to verify Windows Store installations can search for updates |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Ghass-M
approved these changes
Jul 11, 2025
paul-fresquet
deleted the
codex/modifier-le-comportement-de-recherche-de-mise-a-jour
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IsInstalledFromWindowsStoreTesting
dotnet test --no-build(fails: command not found)