[fix] Enable adaptive downscale after client timeouts#291
Merged
Conversation
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Enables adaptive downscaling of upload settings in response to repeated client-side upload timeouts, so uploads can recover by reducing parallelism first and then shrinking chunk size down to a 64 KB floor.
Changes:
- Track consecutive client timeouts and trigger a downscale after a fixed threshold.
- Refactor downscale logic into a shared helper and reuse it for both bandwidth-based and timeout-based downscales.
- Add/adjust unit tests to cover timeout-driven downscale behavior and minimum chunk size behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/ByteSync.Client/Services/Communications/Transfers/Uploading/AdaptiveUploadController.cs |
Adds consecutive-timeout tracking and reuses a unified Downscale(...) path for both timeout and slow-window triggers. |
tests/ByteSync.Client.UnitTests/Services/Communications/Transfers/Uploading/AdaptiveUploadControllerTests.cs |
Adds unit coverage for timeout-driven downscale (parallelism-first and chunk-size floor). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Made-with: Cursor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Test plan