Address warnings from dependencies #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation about the CVE about RCE (similar to Pickle)
Will change to True only for the calls that may possibly load trusted Pickles, not only generic .npz files. https://docs.scipy.org/doc/numpy/reference/generated/numpy.load.html Changed in version 1.16.3: Made default False in response to CVE-2019-6446. Reported by @Wouter-VDP via Slack on 2019-08-08.
Even though these 2x calls load .npz files, they contain NumPy object arrays of ShotList class objects that are implicitly serialized by Pickle via np.savez() calls. Also, fix bug with sorted(ShotList) being converted to a List instead of a ShotList.
Addressing warning: This call to matplotlib.use() has no effect because the backend has already been chosen; matplotlib.use() must be called *before* pylab, matplotlib.pyplot, or matplotlib.backends is imported for the first time.
Collaborator
|
Can one of the admins verify this patch? |
Contributor
|
Add to whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to prevent the noise in stdout from the following packages:
matplotlib: from callingmatplotlib.use()after certain import statementsnumpy: from versions >= 1.6.3 fromnp.load()changes in response to https://nvd.nist.gov/vuln/detail/CVE-2019-6446yaml: also a change in default loading behavior for security reasons