Restore missing Falcon AVX2 ifdef's#492
Merged
thomwiggers merged 2 commits intomasterfrom Jul 19, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/orgs/open-quantum-safe/discussions/1487
Note that I accidentally pushed an earlier commit to master. So master is currently in a broken state while waiting for this PR to land.
This PR does break one of our requirements that we don't use preprocessor macros for feature detection. However I'm not really sure of a way around this. As far as I understand it, the code is necessary on AVX2 in 32-bit builds, but PQClean doesn't distinguish between AVX2 on 32-bit and 64-bit builds. So either we create another PQClean implementation for that scenario, or we allow this ifdef (which, incidentally, was in the original Falcon code, and we stripped it out).