Potential fix for code scanning alert no. 12: Incomplete multi-character sanitization#6
Merged
Merged
Conversation
…ter sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/PRATHAM777P/AlphaMind/security/code-scanning/12
General fix: avoid relying on complex multi-character regex removal of dangerous tags (
<script...>...</script>etc.) as a sanitizer. Instead, perform robust text extraction by removing/neutralizing all markup delimiters (<and>) after entity decoding, or use a vetted HTML sanitizer/parser.Best minimal fix here (without changing intended functionality): keep current extraction logic, but change
decodeEntitiesso it does not decode</>back into</>before stripping. Then, instripTags, continue to remove any literal<...>tags first and finally remove any remaining literal angle brackets. This prevents reintroduction of executable tag syntax through entity decoding and eliminates the incomplete multi-character sanitization concern around the script-removal block.Edit only
src/tools/fetch/web-fetch-utils.ts:decodeEntities, remove replacements that decode<and>.nbsp,quot, numeric,amp) intact.No new imports/dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.