Fix dataloaders #76
Merged
Fix dataloaders #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh1002
requested review from
benemer,
mehermvr and
tizianoGuadagnino
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify all dataloaders to provide scans in the format [raw_frame, timestamps]. This allows us to use the full potential of KISS-ICP with the deskewing module. Additionally, this fix means we can remove the ugly try-catch block in the main
pipeline.py.Remove an unnecessary for loop in the main algorithm, which transforms the
orb_keypointscoordinates.Also bump the minimum version of kiss-icp to their latest release, i.e,. 1.2.3