-
Notifications
You must be signed in to change notification settings - Fork 7
Remove plotting capabilities #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The caret constraint (^5.18.0) was limiting plotly to <6.0.0, causing dependency conflicts for users who want to use plotly 6.x. The codebase only uses stable, basic plotly APIs (go.Bar and plotly.offline.plot) that are compatible with both plotly 5.x and 6.x. https://claude.ai/code/session_01VuwA6zF7mR9zPdgY2Fn8Nn
The statistics module was orphaned code that was never integrated into the CLI or exported from the package. Removing it eliminates the plotly dependency entirely, reducing install conflicts for users. Removed: - pridepy/statistics/ directory - plotly from pyproject.toml, requirements.txt, environment.yml, recipe/meta.yaml https://claude.ai/code/session_01VuwA6zF7mR9zPdgY2Fn8Nn
…y-W3MX1 Remove plotting capabilities of pridepy because they are not exposed on the commandline and not needed
📝 WalkthroughWalkthroughThe PR removes the Plotly visualization library and the Statistics module that generated charts from PRIDE submission data across configuration and source files, simplifying dependencies and code. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨No code suggestions found for the PR. |
PR Type
Enhancement
Description
Remove unused statistics module with plotly dependency
Eliminate plotly from all dependency files
Reduce installation conflicts for users
Bump version to 0.0.12
Diagram Walkthrough
File Walkthrough
statistics.py
Remove unused statistics module entirelypridepy/statistics/statistics.py
plot_monthly_submissions()andplot_submissions_by_instrument()were never integrated into CLIpyproject.toml
Remove plotly dependency and bump versionpyproject.toml
plotly = "^5.18.0"dependencyrequirements.txt
Remove plotly from requirementsrequirements.txt
environment.yml
Remove plotly from conda environmentenvironment.yml
meta.yaml
Remove plotly and update conda recipe versionrecipe/meta.yaml
plotly~=5.22.0from run requirementsSummary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.