Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new connector decorators and modernizes the codebase by adopting file-scoped namespaces and adding connector functionality. The changes primarily focus on adding design-time execution capabilities for connectors and updating the code style to use modern C# syntax.
Key changes include:
- Introduction of connector-related interfaces, models, and attributes for design-time execution
- Migration from traditional namespace braces to file-scoped namespace declarations
- Addition of new decorator attributes for control dependencies and event handling
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
IConnectorAction.cs |
New interface defining connector action capabilities with design-time execution methods |
ConnectorOperationModel.cs |
New model representing connector operations with metadata |
OnEmitControlChangeHandlerAttribute.cs |
New attribute for marking methods that execute when control values change at design time |
DependencyDecoratorAttribute.cs |
New attribute for defining control dependencies with comparison operators |
FEDecoratorAttribute.cs |
Enhanced with new properties for control change event emission |
Operator.cs |
New enum defining comparison operators for dependency evaluations |
| Multiple namespace files | Converted from traditional namespace braces to file-scoped declarations |
.editorconfig |
Added comprehensive C# coding standards configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
corina-rusu
commented
Sep 22, 2025
| using System.Text; | ||
|
|
||
| namespace Ringhel.Procesio.Action.Core.ActionDecorators | ||
| namespace Ringhel.Procesio.Action.Core.ActionDecorators; |
Contributor
Author
There was a problem hiding this comment.
nothing changed in this class other than the indentation because of the file scope namespace putting the ';' here.
cosminprocesio
previously approved these changes
Sep 22, 2025
cosminprocesio
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.