Skip to content

Feature/events ref mail#110

Merged
yakser merged 4 commits into
devfrom
feature/events-ref-mail
Apr 4, 2023
Merged

Feature/events ref mail#110
yakser merged 4 commits into
devfrom
feature/events-ref-mail

Conversation

@XataBq
Copy link
Copy Markdown
Collaborator

@XataBq XataBq commented Mar 23, 2023

Изменены содержания сообщений, отправляемые пользователю при регистрации для подтверждения почты, смене пароля

@XataBq XataBq requested a review from yakser March 23, 2023 15:50
Comment thread events/models.py
from events.constants import VERBOSE_EVENT_TYPE, MAIN_URL

# from django.conf import settings
# from django.contrib.auth.models import User
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

удалить коммент

Comment thread events/models.py
text: A TextField event text content.
short_text: A TextField event short text content.
cover_url: A URLField link to event cover image.
cover_url = models.URLField(null=False)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вернуть докстринг cover_url: A URLField link to event cover image.

Comment thread events/models.py
short_text: A TextField event short text content.
cover_url: A URLField link to event cover image.
cover_url = models.URLField(null=False)
# datetime_created: A DateTimeField indicating date of creation.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишний коммент какой то, че тут творилось вообще аххва. какой то убитый докстринг, нужно поправить

Comment thread events/models.py
# datetime_created: A DateTimeField indicating date of creation.
datetime_created: A DateTimeField indicating date of creation.
datetime_updated: A DateTimeField indicating date of update.
tg_message_id: A IntegerField Telegram messaage id (for edit message)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An IntegerField

Comment thread events/models.py
verbose_name="Дата изменения", null=False, auto_now=True
)
tg_message_id = models.IntegerField(blank=True, null=True)
website_url = models.URLField(null=False, default=MAIN_URL)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мб лучше назвать DEFAULT_URL

Comment thread events/models.py
)
tg_message_id = models.IntegerField(blank=True, null=True)
website_url = models.URLField(null=False, default=MAIN_URL)
event_type = models.PositiveSmallIntegerField(choices=VERBOSE_EVENT_TYPE, default=0)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

нужно дописать урл который возвращает VERBOSE_EVENT_TYPE. /events/types/

@yakser yakser merged commit 1137abe into dev Apr 4, 2023
@yakser yakser deleted the feature/events-ref-mail branch September 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants