Отдельная ручка для списков проектов на которые подписан пользователь#242
Merged
Отдельная ручка для списков проектов на которые подписан пользователь#242
Conversation
Create pagination class in core app
VeryBigSad
suggested changes
Nov 22, 2023
Contributor
VeryBigSad
left a comment
There was a problem hiding this comment.
все идеально, ток поправь class UserSubscribedProjectsList
Comment on lines
+386
to
+393
| user = User.objects.get(pk=self.kwargs["pk"]) | ||
| page = self.paginate_queryset(user.subscribed_projects.all()) | ||
| if page is not None: | ||
| serializer = self.get_serializer(page, many=True) | ||
| return self.get_paginated_response(serializer.data) | ||
| raise exceptions.ValidationError("Unable to return paginated list") | ||
| except User.DoesNotExist: | ||
| raise exceptions.NotFound |
Contributor
There was a problem hiding this comment.
это должно автоматом пагинироваться, нет? Достаточно просто pagination_class добавить
Member
Author
There was a problem hiding this comment.
с кастомным get по моему нет
Member
Author
There was a problem hiding this comment.
Хотя щас попробую натворить кое что
VeryBigSad
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Отдельная ручка для списков проектов на которые подписан пользователь