Refactor/new collaborators/functional

projects/urls.py

@@ -18,6 +18,7 @@
     SwitchLeaderRole,
     LeaveProject,
     DeleteProjectCollaborators,
+    SwitchLeaderRole,
 )
 
 app_name = "projects"
@@ -33,9 +34,12 @@
     path("<int:project_pk>/news/<int:pk>/set_viewed/", NewsDetailSetViewed.as_view()),
     path("<int:project_pk>/news/<int:pk>/set_liked/", NewsDetailSetLiked.as_view()),
     path("<int:pk>/collaborators/", ProjectCollaborators.as_view()),
-    path("<int:pk>/collaborators/switch-leader/", SwitchLeaderRole.as_view()),
-    path("<int:pk>/collaborators/leave/", LeaveProject.as_view()),
-    path("<int:pk>/collaborators/kick/", DeleteProjectCollaborators.as_view()),
+    path("<int:project_pk>/collaborators/leave/", LeaveProject.as_view()),
+    path("<int:project_pk>/collaborators/kick/", DeleteProjectCollaborators.as_view()),
+    path(
+        "<int:project_pk>/collaborators/<int:user_to_leader_pk>/switch-leader/",
+        SwitchLeaderRole.as_view(),
+    ),
     path("<int:pk>/", ProjectDetail.as_view()),
     path("<int:pk>/recommended_users", ProjectRecommendedUsers.as_view()),
     path("count/", ProjectCountView.as_view()),

projects/views.py

@@ -3,7 +3,6 @@
 
 from django.contrib.auth import get_user_model
 from django.core.exceptions import ObjectDoesNotExist
-from django.db.models import Q
 from django.shortcuts import get_object_or_404
 from django.db.models import Q, QuerySet
 from django_filters import rest_framework as filters
@@ -504,14 +503,16 @@ def patch(self, request, pk: int):
 class LeaveProject(generics.GenericAPIView):
     permission_classes = [IsAuthenticated]
 
-    def delete(self, request, pk: int) -> Response:
+    def delete(self, request, project_pk: int) -> Response:
         collaborator = get_object_or_404(
-            Collaborator.objects.all(), project_id=pk, user_id=self.request.user.id
+            Collaborator.objects.all(),
+            project_id=project_pk,
+            user_id=self.request.user.id,
         )
         collaborator.delete()
         return Response(status=204)
-      
-        
+
+
 class DeleteProjectCollaborators(generics.GenericAPIView):
     permission_classes = [IsProjectLeader]
     queryset = Project.objects.all().select_related("leader")
@@ -522,8 +523,9 @@ def _project_data(
         project = self.get_object()
         return project.id, project.leader.id
 
+    @staticmethod
     def _collabs_queryset(
-        self, project_id: int, requested_ids: set[int], leader_id: int
+        project_id: int, requested_ids: set[int], leader_id: int
     ) -> QuerySet:
         return (
             Collaborator.objects.filter(
@@ -533,7 +535,7 @@ def _collabs_queryset(
             .values_list("id", flat=True)
         )
 
-    def delete(self, request, pk: int) -> Response:
+    def delete(self, request, project_pk: int) -> Response:
         requested_collabs_ids: set[int] = set(request.data)
 
         project_id, leader_id = self._project_data()
@@ -556,3 +558,41 @@ def delete(self, request, pk: int) -> Response:
 
         Collaborator.objects.filter(id__in=existing_collabs_ids).delete()
         return Response(status=204)
+
+
+class SwitchLeaderRole(generics.GenericAPIView):
+    permission_classes = [IsProjectLeader]
+    queryset = Project.objects.all().select_related("leader")
+
+    @staticmethod
+    def _get_new_leader(user_id: int, project: Project) -> Collaborator:
+        try:
+            return Collaborator.objects.select_related("user").get(
+                user_id=user_id, project=project
+            )
+        except ObjectDoesNotExist:
+            raise CollaboratorDoesNotExist(
+                f"""Collaborator with user_id: {user_id} does not exist. Either user_id is not correct, or project_id
+                is not correct, or try adding this user to a project (as collaborator) before making them a leader. """
+            )
+
+    @staticmethod
+    def _get_project(project_pk: int) -> Project:
+        return get_object_or_404(Project.objects.all(), id=project_pk)
+
+    def patch(self, request, project_pk: int, user_to_leader_pk: int) -> Response:
+        project = self._get_project(project_pk)
+
+        new_leader_id = user_to_leader_pk
+
+        if project.leader.id == new_leader_id:
+            return Response(
+                {"error": "User is already a leader of a project"},
+                status=status.HTTP_422_UNPROCESSABLE_ENTITY,
+            )
+
+        new_leader = self._get_new_leader(new_leader_id, project)
+
+        project.leader = new_leader.user
+        project.save()
+        return Response(status=204)