Skip to content

Detect PRQL based on language ID rather than file extension#25

Merged
max-sixty merged 1 commit intoPRQL:mainfrom
jiripospisil:language_id
Jan 16, 2023
Merged

Detect PRQL based on language ID rather than file extension#25
max-sixty merged 1 commit intoPRQL:mainfrom
jiripospisil:language_id

Conversation

@jiripospisil
Copy link
Copy Markdown
Contributor

Fixes #24.

@max-sixty
Copy link
Copy Markdown
Member

Looks great to me! Thanks @jiripospisil !

When saving a .prql file, I can confirm it sets the lang to PRQL.

With the proposed code, until the lang is set — either explicitly or with a .prql extension — the output panel won't work — which is probably correct, otherwise it's going to try and parse lots of non-PRQL files.

@max-sixty
Copy link
Copy Markdown
Member

@jiripospisil I'm going to hit the button if that's OK?

@max-sixty max-sixty merged commit f43c778 into PRQL:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support non created file

2 participants