Merged
Conversation
max-sixty
approved these changes
Apr 11, 2022
Member
max-sixty
left a comment
max-sixty
left a comment
There was a problem hiding this comment.
Very nicely implemented! I can't even find something to improve on...
|
|
||
| impl Dialect { | ||
| pub fn use_top(&self) -> bool { | ||
| matches!(self, Dialect::MsSql) |
Member
There was a problem hiding this comment.
Possibly in the future we want to have each Dialect be a Struct that we implement a Trait for — for the moment this is excellent.
Member
|
I will do the docs for this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.