Conversation
aljazerzen
force-pushed
the
reorganize-dirs
branch
from
d5ab2c1 to
798b111
Compare
max-sixty
left a comment
max-sixty
left a comment
There was a problem hiding this comment.
I'm OK with this — it's purely internal.
I'm pro-the approach described at https://matklad.github.io/2021/08/22/large-rust-workspaces.html, but given your contributions I would weigh your vote very highly here.
aljazerzen
force-pushed
the
reorganize-dirs
branch
from
83828f4 to
ad008b3
Compare
aljazerzen
force-pushed
the
reorganize-dirs
branch
from
ffa1330 to
2dedb5c
Compare
aljazerzen
force-pushed
the
reorganize-dirs
branch
from
dc043ff to
b161f28
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
| ".direnv": true, | ||
| ".pytest_cache": true, | ||
| ".mypy_cache": true |
There was a problem hiding this comment.
FWIW I have these in my global settings rather than per-workspace...
|
I see the upgrades have caused merge conflicts. They should be mostly done (they come in each Monday), but feel free to pause them if it's causing you trouble. |
|
@aljazerzen lmk if you want a hand merging this! I worry that as more changes come from elsewhere, git might not be smart enough and the merge will be really difficult. I don't think there's much we can "split off" — you already merged things like the justfile separately... |
for more information, see https://pre-commit.ci
|
Yeah, that'd be great, if you have the time. |
aljazerzen
force-pushed
the
reorganize-dirs
branch
from
8a46fc7 to
9ad8b0e
Compare
for more information, see https://pre-commit.ci
Followup for #3683 Because I've moved a bunch of files, links to github.com repo main branch were broken. So I've disabled the check, merged and now they should work again.
You merged 2 hours later! I'm too online, but not that online. :D |
|
I though more things need fixing :D |
|
Great work! |
|
@eitsupi I was a bit worried you'd have objections to the reorganization, since you have done a lot of work on the bindings, so hearing praises from you means a lot! |
3 participants
Combine compiler "things" into its own dir.
This basically says "bindings are not PRQL bindings, but prqlc bindings". Similar for packages/.
The caveat is that I've shortened the
prqlc/crates/prql-parser/toprqlc/crates/parser, but kept the crate nameprql-parser. We can update this, but I don't want to change the published names "prql-compiler" and "prqlc".