fix: Lineage traces through CTEs to source tables#5581
Merged
Conversation
Previously, CTEs (let statements) were treated as opaque tables in lineage tracking. The lineage would show `table: [cte_name]` instead of tracing back to the actual source tables. Now, lineage properly traces through CTEs to their underlying source tables. For simple CTEs, this shows the original table. For CTEs with UNIONs or JOINs, all source tables are included in the lineage.
for more information, see https://pre-commit.ci
- Simplify lineage_of_table_decl from nested if-let to two match expressions - Add UNIO to typos allowlist (prevents UNIONs -> UNIONNs corruption) - Add test_cte_lineage_traces_to_source_table mentioned in PR description Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
I tried to simplify a bit, with Claude's help — feel free to revert if you preferred the former though |
- Add test_direct_table_lineage_uses_table_itself to exercise the non-CTE code path in lineage_of_table_decl (line 80, 92-96 in inference.rs) - Fix UNIONNs typo in test comment Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@max-sixty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lineage tracking for CTEs (Common Table Expressions) so they properly trace back to their underlying source tables instead of being treated as opaque tables.
Problem
When using a CTE like:
The lineage would incorrectly show:
Solution
Modified
lineage_of_table_declin the resolver to check if a table declaration is a CTE (TableExpr::RelationVar) and, if so, trace back to the underlying source tables.The lineage now correctly shows:
For CTEs with multiple inputs (UNIONs, JOINs), all source tables are included:
Changes
prqlc/prqlc/src/semantic/resolver/inference.rs: Modifiedlineage_of_table_declto trace CTE lineage to underlying source tablesprqlc/prqlc/src/semantic/resolver/mod.rs: Added unit tests for simple CTEs and CTEs with UNIONsintegration__queries__debug_lineage__genre_counts.snapreflects the corrected lineage behaviorTesting
test_cte_lineage_traces_to_source_table- verifies simple CTE lineagetest_cte_lineage_with_union_traces_to_all_source_tables- verifies UNION CTE lineage