Skip to content

Conversation

@prql-bot
Copy link
Collaborator

Automatic change by the update-rust-toolchain Github Action.

Github Actions will not run workflows on pull requests which are opened by a GitHub Action.

For examples on how to run workflows on this pr, please go to the readme.

@prql-bot prql-bot enabled auto-merge (squash) January 23, 2026 11:01
@max-sixty
Copy link
Member

@claude please fix

@claude
Copy link

claude bot commented Jan 23, 2026

Fixing Rust 1.92 Clippy False Positives

  • Gather context and understand the issue
  • Identify root cause: Rust 1.92 unused_assignments bug
  • Apply #![allow(unused_assignments)] at crate level to fix all affected enums
  • Run tests to verify the fix (637 tests passed ✓)
  • Push changes
  • Fix additional CI issue: unused import + formatting in test file
  • Verify CI passes

Changes:

  1. Added #![allow(unused_assignments)] at the crate level in prqlc/prqlc/src/lib.rs to suppress false positive warnings from the enum-as-inner derive macro (rust-lang/rust#147648)
  2. Removed unused env import from prqlc/prqlc/tests/integration/queries.rs and fixed import ordering

Commits:

  • 8b209e3 - fix: suppress false positive unused_assignments warnings in Rust 1.92
  • d2b6c34 - fix: remove unused import env in queries.rs

View job run | View branch

github-actions bot and others added 2 commits January 23, 2026 16:43
Add #![allow(unused_assignments)] at crate level to suppress false positive
warnings introduced by Rust 1.92's stricter lint behavior on code generated
by the enum-as-inner derive macro.

This is a known Rust compiler bug tracked at:
- rust-lang/rust#147648

The fix for enum-as-inner is pending at:
- bluejekyll/enum-as-inner#108

The allow can be removed once enum-as-inner is updated.

Co-Authored-By: Maximilian Roos <max-sixty@users.noreply.github.com>
Rust 1.92's stricter linting caught this unused import.

Co-Authored-By: Maximilian Roos <max-sixty@users.noreply.github.com>
@claude claude bot force-pushed the update_rust_toolchain_action branch from 2b577db to d2b6c34 Compare January 23, 2026 17:04
@prql-bot prql-bot merged commit 1ef8c1b into main Jan 23, 2026
78 checks passed
@prql-bot prql-bot deleted the update_rust_toolchain_action branch January 23, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants