fix: remove leading blank lines from compileall snapshots#5752
Merged
fix: remove leading blank lines from compileall snapshots#5752
Conversation
Skip empty diffs (where dialect output matches generic) instead of including them, which produced leading/intermediate blank lines in the snapshot files. Closes follow-up from #5750. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
@prql-bot look at what happened re the auto-merge Now that we have the merge protection, we should disable the automerge; can you open a PR for this? |
2 tasks
Collaborator
Author
|
The Opened #5753 to remove the |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compilealltest snapshot generation to skip empty diffs (where a dialect's output matches generic SQL), eliminating leading and intermediate blank lines in.snapfilesunified_diff()returns an empty string when there's no difference, but those empty strings were still being collected and joined with newlinesFollow-up from #5750 (requested here).
Test plan
compileallsnapshots regenerated without blank lines at the topcargo test -p prqlcpasses (449 passed, 0 failed)🤖 Generated with Claude Code