Conversation
…highlighting The number-highlighting regex had a stray `]` in `(\.[\d_]+])?`, so decimals like `123.45` were only highlighted as `123` — the fractional part failed to match. The `TRANSFORMS` list also diverged from `std.prql`: it contained `union` (not a built-in transform — it's defined as an example user function in `append.md`) and was missing `intersect`, `remove`, and `loop` (which are defined in `std.prql`). No tests: the playground tokenizer has no existing test harness and testing a Monaco tokenizer would require a Monaco mock. Verified by reading \`prqlc/prqlc/src/semantic/std.prql\` against the list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
]in the number-highlighting regex — decimals like123.45were only highlighting123(the fractional part failed to match)TRANSFORMSlist withprqlc/prqlc/src/semantic/std.prql:union(it is not a built-in transform — it is shown as an example user-defined function in append.md#L44)intersect,remove, andloop(all defined instd.prql)Test plan
The playground tokenizer has no existing test harness; testing it would require a Monaco mock, which felt disproportionate for a two-character fix. Findings surfaced during nightly code survey of
web/playground/src/workbench/prql-syntax.js.🤖 Generated with Claude Code