feat!: remove deprecated std.prql_version#5806
Conversation
The deprecation notice promised removal in PRQL 0.12.0, but the function is still present in 0.13.12. Either the removal needs to happen or the timeline was wrong; for now, drop the specific version so the docs stop contradicting the code. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
let's instead remove it! |
Per maintainer feedback on #5806, remove the function rather than just updating the stale deprecation note. `prql.version` has been the supported replacement since 0.11.1. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Done — pushed 40ecc1e. Dropped |
prql-bot
left a comment
There was a problem hiding this comment.
Self-review after switching approach on maintainer feedback. The code change itself is clean — std.prql_version is dropped, the deprecation note is removed from target.md, and the ID shifts propagate mechanically through the debug-lineage snapshots. No user-facing references to std.prql_version remain; the "prql_version" string in prqlc/prqlc/src/semantic/resolver/transforms.rs:442 is the intrinsic name still used by prql.version.
A few cleanup items before merge:
- PR title and body are stale. The title still reads
docs:and the body says the function is "left in place" — both describe the first commit's approach. The second commit (feat: remove deprecated std.prql_version) is the final state. Sincestd.prql_versionwas documented and removing it will fail any query that still calls it,feat!:would more accurately signal the breaking removal. - Missing CHANGELOG entry.
[unreleased]→**Language**is empty. The 0.11.1 entry noted the deprecation, so the actual removal deserves a matching bullet pointing users atprql.version.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
|
Addressed both self-review items in b57b779 and by updating the PR metadata:
|
Summary
The deprecation notice for
std.prql_versionpromised removal in PRQL 0.12.0, but we're now at 0.13.12 and the function was still present. Per maintainer feedback (@max-sixty), this PR removes the function rather than just updating the stale deprecation note.prql.versionhas been the supported replacement since 0.11.1, so this is a breaking removal for any query still callingstd.prql_versiondirectly.Found during the nightly survey of
web/book/src/project/target.md.Changes
std.prql_versionfromprqlc/prqlc/src/semantic/std.prqlweb/book/src/project/target.md[unreleased]→ Language CHANGELOG entry pointing users atprql.versionTest plan
task prqlc:testpassesprql.versionstill compiles (existingshortest_prql_versiontest covers this)std.prql_versionsurfaces a normal "unknown name" error for any query that still calls it