Skip to content

feat!: remove deprecated std.prql_version#5806

Merged
max-sixty merged 4 commits intomainfrom
fix/stale-prql-version-deprecation-note
Apr 17, 2026
Merged

feat!: remove deprecated std.prql_version#5806
max-sixty merged 4 commits intomainfrom
fix/stale-prql-version-deprecation-note

Conversation

@prql-bot
Copy link
Copy Markdown
Collaborator

@prql-bot prql-bot commented Apr 17, 2026

Summary

The deprecation notice for std.prql_version promised removal in PRQL 0.12.0, but we're now at 0.13.12 and the function was still present. Per maintainer feedback (@max-sixty), this PR removes the function rather than just updating the stale deprecation note.

prql.version has been the supported replacement since 0.11.1, so this is a breaking removal for any query still calling std.prql_version directly.

Found during the nightly survey of web/book/src/project/target.md.

Changes

  • Drop std.prql_version from prqlc/prqlc/src/semantic/std.prql
  • Remove the deprecation note from web/book/src/project/target.md
  • Update debug-lineage snapshots where the removal shifted intrinsic IDs
  • Add [unreleased]Language CHANGELOG entry pointing users at prql.version

Test plan

  • task prqlc:test passes
  • prql.version still compiles (existing shortest_prql_version test covers this)
  • Removing std.prql_version surfaces a normal "unknown name" error for any query that still calls it

The deprecation notice promised removal in PRQL 0.12.0, but the function
is still present in 0.13.12. Either the removal needs to happen or the
timeline was wrong; for now, drop the specific version so the docs stop
contradicting the code.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@max-sixty
Copy link
Copy Markdown
Member

let's instead remove it!

Per maintainer feedback on #5806, remove the function rather than just
updating the stale deprecation note. `prql.version` has been the
supported replacement since 0.11.1.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@prql-bot
Copy link
Copy Markdown
Collaborator Author

Done — pushed 40ecc1e. Dropped std.prql_version from std.prql and removed the deprecation note from target.md. prql.version is unaffected and all tests pass.

Copy link
Copy Markdown
Collaborator Author

@prql-bot prql-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review after switching approach on maintainer feedback. The code change itself is clean — std.prql_version is dropped, the deprecation note is removed from target.md, and the ID shifts propagate mechanically through the debug-lineage snapshots. No user-facing references to std.prql_version remain; the "prql_version" string in prqlc/prqlc/src/semantic/resolver/transforms.rs:442 is the intrinsic name still used by prql.version.

A few cleanup items before merge:

  • PR title and body are stale. The title still reads docs: and the body says the function is "left in place" — both describe the first commit's approach. The second commit (feat: remove deprecated std.prql_version) is the final state. Since std.prql_version was documented and removing it will fail any query that still calls it, feat!: would more accurately signal the breaking removal.
  • Missing CHANGELOG entry. [unreleased]**Language** is empty. The 0.11.1 entry noted the deprecation, so the actual removal deserves a matching bullet pointing users at prql.version.

prql-bot and others added 2 commits April 17, 2026 07:59
@prql-bot prql-bot changed the title docs: remove stale 0.12.0 removal claim for std.prql_version feat!: remove deprecated std.prql_version Apr 17, 2026
@prql-bot
Copy link
Copy Markdown
Collaborator Author

Addressed both self-review items in b57b779 and by updating the PR metadata:

  • PR title → feat\!: to signal the breaking removal; body rewritten to describe the final state
  • Added CHANGELOG [unreleased]Language entry pointing users at prql.version

@max-sixty max-sixty merged commit d54dcdd into main Apr 17, 2026
40 checks passed
@max-sixty max-sixty deleted the fix/stale-prql-version-deprecation-note branch April 17, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants