fix: correct stale macro name in prqlc-macros panic message#5811
Merged
fix: correct stale macro name in prqlc-macros panic message#5811
Conversation
The macro is `prql_to_sql\!`, not `prql\!`. Aligns the error message with the macro's actual name. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
prqlc-macroscrate exports a single proc macro:prql_to_sql!. The panic message for non-string input still references the oldprql!name, which would mislead users encountering the error.No regression test — adding one would require deliberately failing macro expansion, which would block compilation. The change is a one-line text fix.
Found during nightly code survey of
prqlc/prqlc-macros/src/lib.rs.